Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to pnpm 9.0.5 #3904

Merged
merged 1 commit into from
Apr 25, 2024
Merged

upgrade to pnpm 9.0.5 #3904

merged 1 commit into from
Apr 25, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented Apr 22, 2024

Test plan

CI

@sqs sqs requested a review from a team April 22, 2024 20:06
@sqs
Copy link
Member Author

sqs commented Apr 23, 2024

pnpm 9 does not support node 16. I will investigate if node 16 support is still needed.

https://pnpm.io/installation#compatibility

My recommendation is that we should stop testing and supporting Node 16, and instead bump this to Node 18.

#3907

@sqs sqs force-pushed the sqs/upgrade-pnpm-905 branch 3 times, most recently from 45e3e22 to e06d875 Compare April 25, 2024 03:42
@sqs sqs merged commit b1c91e3 into main Apr 25, 2024
19 of 20 checks passed
@sqs sqs deleted the sqs/upgrade-pnpm-905 branch April 25, 2024 07:49
sqs added a commit that referenced this pull request Apr 26, 2024
This reverts commit b1c91e3.

Breaks JetBrains extension CI because the jetbrains repo requires both cody and sourcegraph/sourcegraph, and the latter can't upgrade to pnpm 9 because it is not yet supported by https://github.com/aspect-build/rules_js.
sqs added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants